Add Svrsw60t59b extension #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ved-rivos
commented
Mar 15, 2025
ved-rivos
commented
- The encoding.h could not be generated due to a build issue in riscv-opcodes. Will replace with auto-generated encoding.h after the issue is resolved.
- Extension is in draft state.
11 tasks
aswaterman
reviewed
Mar 17, 2025
Collaborator
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
LGTM, but we'll leave this as an open PR until it appears that it'll freeze.
Collaborator
|
@ved-rivos I think it's safe to incorporate this now. Can you rebase and fix the merge conflicts? |
Contributor
Author
|
@aswaterman - could you please merge the riscv-opcodes PR riscv/riscv-opcodes#349 so I can use the encoding.h from master for this PR. |
Collaborator
|
Done. |
ved-rivos
force-pushed
the
svrsw60t59b
branch
from
cd3dea8 to
8eaeed0
Compare
ved-rivos
force-pushed
the
svrsw60t59b
branch
from
8eaeed0 to
5ea30aa
Compare
aswaterman
approved these changes
Nov 14, 2025
Contributor
Author
|
@aswaterman - this is rebased and ready. |
Collaborator
|
Cool, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.