Remove CI tarball; build tests in CI #2096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryz123
approved these changes
Oct 1, 2025
aswaterman
force-pushed
the
remove-ci-tarball
branch
2 times, most recently
from
43fee25 to
2b52daa
Compare
aswaterman
force-pushed
the
remove-ci-tarball
branch
2 times, most recently
from
2c2d35f to
7cd767e
Compare
aswaterman
force-pushed
the
remove-ci-tarball
branch
from
7cd767e to
e360efb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason we were building the tarball offline is to avoid the time-consuming task of building a RISC-V GCC toolchain. Since we can install one in Ubuntu-package form now, we might as well build the tests online, since that part is speedy.
Unfortunately, relying on an Ubuntu package means we can't build and run the tests on Mac OS. But I think that's OK. The main virtue of testing against Mac OS in CI is to make sure the build doesn't fail.