Add configurable datacount for debug module #2105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkhaidari
force-pushed
the
fk-sc/configurable-datacount
branch
from
c4b3cf5 to
5a6f947
Compare
Contributor
Author
|
@aswaterman, @arrv-sc, could you take a look? |
Contributor
Author
|
I've mentioned this feature in #2086 |
This commit adds support for configuring the number of data registers available in the debug module. Previously, the debug module had a fixed datasize of 2, but now users can specify the number of data registers using the --dm-datacount option when running spike. The changes include: - Adding a datacount parameter to debug_module_config_t - Making dmdata a std::vector instead of a fixed array - Validating that datacount is between 1 and 12 - Updating the debug module to use the configured datacount - Adding command-line option to set datacount - Updating documentation in help output Signed-off-by: Farid Khaydari <[email protected]>
fkhaidari
force-pushed
the
fk-sc/configurable-datacount
branch
from
5a6f947 to
5397899
Compare
aswaterman
reviewed
Oct 14, 2025
| std::find_if(debug_memory_regions.begin(), debug_memory_regions.end(), | ||
| [addr, len](const auto &range) { | ||
| return belongs_to_range(addr, len, range.addr, range.len); | ||
| }); |
Collaborator
There was a problem hiding this comment.
This is obviously going to perform somewhat more poorly than the old code, but I think that's OK in this context; Spike should not be spending much time in these routines in normal operation.
Collaborator
|
@arrv-sc I'll wait for your approval before I merge. |
Collaborator
|
LGTM! |
arromanoff
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for configuring the number of data registers available in the debug module. Previously, the debug module had a fixed datasize of 2, but now users can specify the number of data registers using the --dm-datacount option when running spike.
The changes include: