Skip to content

Two Zicfilp improvements #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aswaterman merged 2 commits into from
Nov 14, 2025
Merged

Two Zicfilp improvements #2147

aswaterman merged 2 commits into from
Nov 14, 2025

Conversation

@aswaterman
Copy link
Collaborator

@aswaterman aswaterman commented Nov 14, 2025 •
edited
Loading

  • Fix an escape where if the I$ was incoherent with main memory, the landing-pad MSBs would not be checked. (For obvious reasons, this was only possible with Ziccid turned off.)
  • Significantly speed up function returns by moving most of the ELP overhead off the critical code path.

@aswaterman
Handle uncommon JALR cases with a tail call
56c416d 
Avoids establishing a stack frame.
@aswaterman
Fix potential landing pad escape
cd3df04 
If main memory contained an LPAD instruction but the incoherent I$ contained
an unrelated instruction, then the landing-pad MSBs would not have been
checked.  Fix by making the I$ coherent with the LPAD when the initial
landing-pad check is performed.
@aswaterman
Copy link
Collaborator Author

aswaterman commented Nov 14, 2025

FYI @ved-rivos

@ved-rivos
Copy link
Contributor

ved-rivos commented Nov 14, 2025

LGTM!

@aswaterman aswaterman merged commit 5bea40c into master Nov 14, 2025
3 checks passed
@aswaterman aswaterman deleted the zicfilp-improvements branch November 14, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aswaterman @ved-rivos