Fix Q extension on big-endian targets #2176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous routines always stored the low-order bits into the low-order doubleword, which is only correct on little-endian targets.
Contributor
|
@aswaterman looks right to me. |
Collaborator
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous routines always stored the low-order bits into the low-order doubleword, which is only correct on little-endian targets.
@ved-rivos can you sanity-check this? I spotted it after seeing your comment here: riscv/riscv-isa-manual#2447 (comment)
The idea is to make FLQ/FSQ look more like AMOCAS.Q etc. rather than a special case.