Add param name/names to error messages#222
Merged
Merged
Conversation
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Copilot started reviewing on behalf of
James Ball (james-ball-qualcomm)
March 19, 2026 20:17
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Improves diagnostics in the parameter definition generator by including the parameter name(s) in validation error messages, making it easier to pinpoint malformed entries in input YAML.
Changes:
- Parse
name/namesearlier inadd_parameter_entriesto build aparam_refstring. - Update multiple
fatal(...)validation messages to includeparam_ref(name(s)) plusdef_filename.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…st one entry. Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Copilot started reviewing on behalf of
James Ball (james-ball-qualcomm)
March 19, 2026 20:47
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.