[scalar-crypto] Importing up-to-date SAIL code for Zkn's aes64ks1i instruction #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…struction The current version of the pseudo SAIL code in the spec did not match the version implemented in sail-riscv. A difference in the code could lead to confusion for round number 0xA (10).
aswaterman
approved these changes
Jul 28, 2025
Member
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
OK with me, let me know when it's ready to merge.
Contributor
Author
Thx @aswaterman , I would like the original editor(s) of the scalar crypto spec to chip in before I go forward with requesting integration. |
Member
|
@nibrunieAtSi5 any update on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the pseudo SAIL code in the spec did not match the version implemented in sail-riscv. A difference in the code could lead to confusion for round number 0xA (10).
Suggestion to address riscv/riscv-crypto#399