Skip to content

Add Sspmp, Sspmpen, and Smpmpdeleg extension definitions#1817

Open
Bicheng Yang (ybc-alkaid) wants to merge 6 commits into
riscv:mainfrom
ybc-alkaid:spmp
Open

Add Sspmp, Sspmpen, and Smpmpdeleg extension definitions#1817
Bicheng Yang (ybc-alkaid) wants to merge 6 commits into
riscv:mainfrom
ybc-alkaid:spmp

Conversation

@ybc-alkaid

Copy link
Copy Markdown
Member

This PR adds Unified Database extension definitions for RISC-V S-level Physical Memory Protection (SPMP), consisting of three extensions:

Sspmp: Core SPMP mechanism for S-mode memory protection.
Sspmpen: Per-entry enable bits via the spmpen CSR.
Smpmpdeleg: PMP-to-SPMP resource sharing via the mpmpdeleg CSR.

References:
SPMP specification: riscv/riscv-isa-manual#2573
SPMP arch test suites: riscv/riscv-arch-test#1166

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Unified Database (UDB) extension definitions for the RISC-V Supervisor Physical Memory Protection (SPMP) feature set, capturing the base mechanism and two related CSRs for enable control and delegation from PMP.

Changes:

  • Add a new privileged extension definition for Sspmp (Supervisor Physical Memory Protection).
  • Add a new privileged extension definition for Sspmpen (per-entry enable control via spmpen).
  • Add a new privileged extension definition for Smpmpdeleg (delegation control via mpmpdeleg).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
spec/std/isa/ext/Sspmp.yaml Defines the core SPMP supervisor protection mechanism and its dependencies.
spec/std/isa/ext/Sspmpen.yaml Defines Sspmpen and requires Sspmp as a prerequisite.
spec/std/isa/ext/Smpmpdeleg.yaml Defines Smpmpdeleg (PMP-to-SPMP resource sharing) and its base privilege requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread spec/std/isa/ext/Sspmpen.yaml Outdated
Comment thread spec/std/isa/ext/Sspmp.yaml Outdated
Comment thread spec/std/isa/ext/Sspmp.yaml Outdated
Comment thread spec/std/isa/ext/Smpmpdeleg.yaml Outdated
Comment thread spec/std/isa/ext/Smpmpdeleg.yaml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Bicheng Yang <SuperYbc@outlook.com>
Copilot AI review requested due to automatic review settings April 30, 2026 16:22
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.18%. Comparing base (a1225d7) to head (01da5ef).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1817      +/-   ##
==========================================
- Coverage   72.24%   72.18%   -0.07%     
==========================================
  Files          52       53       +1     
  Lines       27671    27865     +194     
  Branches     6009     6031      +22     
==========================================
+ Hits        19992    20114     +122     
- Misses       7679     7751      +72     
Flag Coverage Δ
idlc 76.08% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread spec/std/isa/ext/Smpmpdeleg.yaml Outdated
Comment thread spec/std/isa/ext/Smpmpdeleg.yaml Outdated
Comment thread spec/std/isa/ext/Sspmpen.yaml Outdated
Comment thread spec/std/isa/ext/Sspmp.yaml Outdated
Copilot AI review requested due to automatic review settings May 5, 2026 16:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread spec/std/isa/ext/Sspmp.yaml
Comment thread spec/std/isa/ext/Sspmp.yaml
Comment thread spec/std/isa/ext/Sspmp.yaml Outdated
Comment thread spec/std/isa/ext/Sspmp.yaml
Comment thread spec/std/isa/ext/Smpmpdeleg.yaml Outdated
Copilot AI review requested due to automatic review settings May 6, 2026 01:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread spec/std/isa/ext/Smpmpdeleg.yaml
Comment thread spec/std/isa/ext/Sspmpen.yaml
Comment thread spec/std/isa/ext/Sspmp.yaml

@dhower-qc Derek Hower (dhower-qc) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xqci@0.13.0.adoc should be restored. that is the merge conflict

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Bicheng Yang <SuperYbc@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants