Skip to content

feat(storage): bump OpenDAL to v0.51 #20084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(storage): bump OpenDAL to v0.51 #20084

wants to merge 2 commits into from

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Jan 9, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, release changes refer to upgrade doc, we don't need to specific the MetaKey when listing.

I will trigger longevity test in aws, gcp and azure environment, and trigger performance test to compare with daily, so let's hold this pr after all test results looks happy.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@wcy-fdu wcy-fdu requested a review from a team as a code owner January 9, 2025 07:26
@wcy-fdu wcy-fdu requested a review from stdrc January 9, 2025 07:26
stdrc
stdrc reviewed Jan 9, 2025
View reviewed changes
src/object_store/src/object/opendal_engine/opendal_s3.rs
Comment on lines +111 to 112
#[allow(deprecated)]
Ok(HttpClient::build(client_builder)?)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an OpenDAL api? Any non-deprecated substitution?

stdrc
stdrc approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Jan 9, 2025

longevity test on aws

I trigger the longevity test on azure and gcp but failed, the test backend of azure and gcp have some issues and @cyliu0 is working on fixing. Will test it later.
Perf test is on the way.

@wcy-fdu wcy-fdu requested a review from hzxa21 January 9, 2025 08:33
@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Jan 13, 2025

Performance test result build 5056 and build 5057 is opendal v0.51, comparing with nightly-20250109

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025

This PR has been open for 60 days with no activity.

If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it.

If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the no-pr-activity label.

You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏)
Don't worry if you think the PR is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdrc stdrc stdrc approved these changes

@hzxa21 hzxa21 Awaiting requested review from hzxa21

Assignees
No one assigned
Labels
no-pr-activity type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wcy-fdu @stdrc