refactor: reduce log verbosity #21184
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
reviewed
Apr 1, 2025
| @@ -128,7 +128,7 @@ impl Sender { | |||
| Message::Chunk(c) => { | |||
| let card = c.cardinality().clamp(1, self.max_chunk_permits); | |||
| if card == self.max_chunk_permits { | |||
| tracing::warn!(cardinality = c.cardinality(), "large chunk in exchange") | |||
| tracing::debug!(cardinality = c.cardinality(), "large chunk in exchange") | |||
There was a problem hiding this comment.
debug means that we are not able to see it in production anymore. Is it still expected?
There was a problem hiding this comment.
I’m okay with keeping it at WARN if it aids in troubleshooting.
There was a problem hiding this comment.
Let's keep it at WARN, I think it suggests some issue on the user side if this warning keeps showing up. It can affect our backpressure mechanism if chunks are too large.
wenym1
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
Highest Release Version: 2.3
What's changed and what's your intention?
close #21181
Checklist
Documentation
Release note