Skip to content

Conversation

@kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Apr 24, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

It didn't switch the connector type previously. Closes #21525.
We also fix the duplicate entry error for on conflict do update, by just batching at most one row at a time.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@kwannoel kwannoel requested review from chenzl25 and zwang28 April 24, 2025 06:08
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Apr 24, 2025
@kwannoel kwannoel force-pushed the kwannoel/switch branch 2 times, most recently from eab0be2 to aa39db9 Compare April 24, 2025 08:02
@kwannoel kwannoel changed the base branch from main to graphite-base/21543 April 24, 2025 08:07
@kwannoel kwannoel force-pushed the graphite-base/21543 branch from 55e9f4c to df17dd2 Compare April 24, 2025 08:07
@kwannoel kwannoel changed the base branch from graphite-base/21543 to kwannoel/on_insert_do_update April 24, 2025 08:08
Copy link
Contributor Author

kwannoel commented Apr 24, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kwannoel kwannoel force-pushed the kwannoel/on_insert_do_update branch from df17dd2 to d69a634 Compare April 24, 2025 08:09
@kwannoel kwannoel force-pushed the kwannoel/switch branch 6 times, most recently from 93e8426 to bb896f3 Compare April 24, 2025 14:33
@kwannoel kwannoel force-pushed the kwannoel/on_insert_do_update branch from 8c95eb9 to 49532a6 Compare April 24, 2025 16:47
@kwannoel kwannoel force-pushed the kwannoel/switch branch 2 times, most recently from bae588c to 72e79ae Compare April 25, 2025 03:01
@kwannoel
Copy link
Contributor Author

A

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

* **[fix(stream): switch `jdbc_pg_to_native` sink #21543](https://github.com/risingwavelabs/risingwave/pull/21543)** [<img alt="Graphite" width="10px" height="10px" src="https://camo.githubusercontent.com/365768b8448b91ea2b5fe3f944937f2edadca0c3fcbf75ad736e4f514a26889c/68747470733a2f2f7374617469632e67726170686974652e6465762f67726170686974652d33327833322d626c61636b2e706e67">](https://app.graphite.dev/github/pr/risingwavelabs/risingwave/21543?utm_source=stack-comment-icon) 👈 [(View in Graphite)](https://app.graphite.dev/github/pr/risingwavelabs/risingwave/21543?utm_source=stack-comment-view-in-graphite)

* **[fix(connector): use the right schema for delete parameters #21566](https://github.com/risingwavelabs/risingwave/pull/21566)** [<img alt="Graphite" width="10px" height="10px" src="https://camo.githubusercontent.com/365768b8448b91ea2b5fe3f944937f2edadca0c3fcbf75ad736e4f514a26889c/68747470733a2f2f7374617469632e67726170686974652e6465762f67726170686974652d33327833322d626c61636b2e706e67">](https://app.graphite.dev/github/pr/risingwavelabs/risingwave/21566?utm_source=stack-comment-icon)

* **[fix(connector): use `insert on conflict do update` for postgres sink #21523](https://github.com/risingwavelabs/risingwave/pull/21523)** [<img alt="Graphite" width="10px" height="10px" src="https://camo.githubusercontent.com/365768b8448b91ea2b5fe3f944937f2edadca0c3fcbf75ad736e4f514a26889c/68747470733a2f2f7374617469632e67726170686974652e6465762f67726170686974652d33327833322d626c61636b2e706e67">](https://app.graphite.dev/github/pr/risingwavelabs/risingwave/21523?utm_source=stack-comment-icon)

* `main`

This stack of pull requests is managed by Graphite. Learn more about stacking.

All 3 PRs got approved. I'll just merge the top-most PR in the stack directly to main, and close the rest.
Makes it easier to cherry-pick into release branches.

@kwannoel kwannoel changed the base branch from kwannoel/fix_delete_parameters to main April 28, 2025 08:38
@xiangjinwu
Copy link
Contributor

xiangjinwu commented Apr 28, 2025

Makes it easier to cherry-pick into release branches.

This is why I wanted to reduce our cherry-pick workload. It is encouraging monolithic commits cc @hzxa21

👍 on splitting it into 3 PRs despite it is going to be 1 merge commit

@kwannoel kwannoel added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit 63cc14e Apr 28, 2025
25 of 27 checks passed
@kwannoel kwannoel deleted the kwannoel/switch branch April 28, 2025 10:49
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 28, 2025
kwannoel added a commit that referenced this pull request May 15, 2025
kwannoel added a commit that referenced this pull request May 15, 2025
kwannoel added a commit that referenced this pull request May 15, 2025
kwannoel added a commit that referenced this pull request May 18, 2025
kwannoel added a commit that referenced this pull request May 30, 2025
kwannoel added a commit that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need-cherry-pick-since-release-2.1 type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create jdbc sink when stream_switch_jdbc_pg_to_native is set to true fails

6 participants