Delay adding helper method to on_load#105
Open
benningm wants to merge 1 commit into
Open
Conversation
Autoloading within initilizers is deprecated in rails 6.0. Adding helper method to ActionController::Base during initialization will trigger autoloading it. This delays adding the helper methods using an on_load() hook for all rails version >= 6.
|
Is there any chance this will get merged? |
|
I second the question from @jbeker |
Th0t
added a commit
to Th0t/rails-jquery-autocomplete
that referenced
this pull request
Oct 23, 2020
|
This gem is on the verge of becoming useless when Rails 6.2 is released because of this. |
BenMcH
added a commit
to BenMcH/rails-jquery-autocomplete
that referenced
this pull request
Aug 25, 2021
Full credit for this patch goes to benningm at this PR: risuiowa#105 The original author has not merged this PR in 2 years, so I am making this patch as to not be a blocker for rails 6 projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Autoloading within initilizers is deprecated in rails 6.0.
Adding helper method to ActionController::Base during initialization
will trigger autoloading it.
This delays adding the helper methods using an on_load() hook for
all rails version >= 6.