Conversation
…elds (ritik4ever#770) - Add PATCH /api/bounties/:id endpoint accepting title, description, labels, deadline - Validate with patchBountySchema (Zod) using .passthrough() + superRefine to explicitly reject immutable fields (amount, status, contributor, tokenSymbol, repo, issueNumber) with a clear validation error - Require maintainer auth via createStellarSignatureAuthMiddleware - Emit a patch_fields audit-log entry with a full field diff (field_from / field_to) - Add patch_fields to BountyTransitionType in bountyStore.ts - Add patchBountyFields() store function with withStoreLock, diff detection, and cache invalidation - Add patch_fields to bountyAuditLogSchema transition enum - Add 19 tests in api.patchBounty.test.ts covering: - Happy-path patches (title, description, labels, deadline, multi-field, no-op) - Audit log diff recording - Authorization rejection for non-owning maintainers - Immutable field rejection (amount, status, contributor) - Validation edge cases (no fields, too short, too many labels, past deadline, unknown ID, missing Content-Type) Closes ritik4ever#770
|
@Abba073 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Abba073 is attempting to deploy a commit to the ritik4ever's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #770 — a generic PATCH endpoint for maintainer-editable bounty fields.
Changes
backend/src/validation/schemas.tspatchBountySchemawith Zod validation fortitle,description,labels,deadline.passthrough()+superRefineto explicitly reject immutable fields (amount,status,contributor,tokenSymbol,repo,issueNumber) with a clear validation error per fieldpatch_fieldstobountyAuditLogSchematransition enumbackend/src/services/bountyStore.tspatch_fieldstoBountyTransitionTypepatchBountyFields()store function with file lock, maintainer ownership check, field diffing, and no-op detectionpatch_fieldsaudit-log entry withfield_from/field_tometadata for each changed fieldbackend/src/app.tsPATCH /api/bounties/:idroute withmutationLimiter,requireJsonContentType,createStellarSignatureAuthMiddleware,validateBody(patchBountySchema)backend/test/api.patchBounty.test.ts(new)Acceptance Criteria
amount) is rejected with a validation errorCloses #770