supports multiselect #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
multi select should be optional. It should default to single select. Also in that case test is required. |
|
Sure it should, maybe add boolean prop "multi", do you care to do it? |
|
I won't be able to do it now due to work. Will do once I have time. You can actually use react-select for that use case. |
|
React-select does not support fuzzy search , i need this functionality |
|
@PatrickDesign can you please check if this is still relevant ? |
|
@ritz078 Having looked at the code, I believe a multi-select could be built around our component (although the dropdown would close on each selection). Maybe the problem could be solved in a simpler way, i.e. a Leaving this PR open in case anybody has more to chip in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please check this PR, as now it supports multiselect, maybe if you release different versions