bugfix: use correct AudioSource for Android 6 and above #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android Marshmallow (6) and above, no recordings were possible and no files would be created. Instead, we get an error message regarding audio capture. [This issue](riul88#41), however, briefly describes the solution, which is basically this patch. Now the calls seems to be recorded correclty (tested on Android 6.0.1). Note that even though the source says just `MIC`, both voices in the call are captured.
|
@kristianlm Could you please provide the compiled apk for this fixed version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android Marshmallow (6) and above, no recordings were possible and
no files would be created. Instead, we get an error message regarding
audio capture.
This issue, however, briefly describes the solution, which is basically this patch.
Now the calls seems to be recorded correclty (tested on Android
6.0.1).
Note that even though the source says just
MIC, both voices in thecall are captured.