Patch to include RiveLogger in RiveRuntime.h#375
Open
nedimf wants to merge 1 commit intorive-app:mainfrom
Open
Patch to include RiveLogger in RiveRuntime.h#375nedimf wants to merge 1 commit intorive-app:mainfrom
nedimf wants to merge 1 commit intorive-app:mainfrom
Conversation
Collaborator
|
Interesting. Which version of the runtime are you trying this with? Our Preview scheme uses the Swift package directly, and modifies the Rive logger, which is also marked as |
Author
|
I was trying it directly in Swift, Xcode wouldn't recognize it. |
Collaborator
|
Does this fail in a brand new project? Can you try and create a minimal reproduction? I've created tons of sample / test apps and never run into this, so I'm not quite sure what could be going on. As I mentioned, that header doesn't even exist, so I'm unsure how the compiler wouldn't error about that addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
According to Rive’s documentation on logging, developers should be able to use RiveLogger to debug animation state and transitions. However, when integrating Rive via Swift Package Manager (SPM), RiveLogger is not exposed to the consumer project, making it inaccessible in Xcode.
Fix:
Added #import <RiveRuntime/RiveLogger.h> to RiveRuntime.h to expose RiveLogger to SPM consumers.
This change allows developers using Rive via SPM to leverage Rive’s built-in logging capabilities as intended, without having to manually modify package internals or resort to workarounds.
Tested:
Confirmed that enabling logs with RiveLogger.isEnabled = true now compiles and outputs logs correctly in Xcode when integrated through SPM.