Add the Quick Start example to the React Native example app #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive Quick Start example to the React Native example app, demonstrating key Rive functionality including data binding, view model properties, and triggers.
- Adds a new QuickStart.tsx component showcasing Rive React Native integration patterns
- Integrates the Quick Start example into the app navigation and home screen
- Includes the required quick_start.riv asset file in the iOS project configuration
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| example/ios/example.xcodeproj/project.pbxproj | Adds quick_start.riv asset to iOS project resources and simplifies OTHER_LDFLAGS configuration |
| example/app/index.tsx | Adds Quick Start navigation link to the home screen |
| example/app/_layout.tsx | Registers the Quick Start screen in the navigation stack |
| example/app/(examples)/QuickStart.tsx | Implements the comprehensive Quick Start example component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+42
to
+49
| const handleTakeDamage = () => { | ||
| if (health && setHealth) { | ||
| setHealth(health - 7); | ||
| // If all state machines have settled, you might need to wake the state machine back up. | ||
| // This can happen when all animations have finished playing. | ||
| riveRef?.play(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
The magic number 7 for damage amount should be extracted to a named constant to improve code readability and maintainability.
Comment on lines
+51
to
+56
| const handleMaxHealth = () => { | ||
| if (setHealth) { | ||
| setHealth(100); | ||
| riveRef?.play(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
The magic number 100 for maximum health should be extracted to a named constant to improve code readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the one we'd like to have for all runtimes.
CleanShot.2025-09-23.at.16.42.04.mp4