Fix "failed to get surface texture: Timeout" issue with viewer (Plus update dependencies)#16
Open
McMackety wants to merge 2 commits intorive-app:mainfrom
Open
Fix "failed to get surface texture: Timeout" issue with viewer (Plus update dependencies)#16McMackety wants to merge 2 commits intorive-app:mainfrom
McMackety wants to merge 2 commits intorive-app:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you clone mainline rive-rs and attempt to run the viewer with a file that has no animations, the viewer panics with the following error:

File: https://chasem.nyc3.cdn.digitaloceanspaces.com/GitHub/Static%20File.riv
Based on my debugging, this seems to be a bug with the version of wgpu being used by vello that is specific to the Vulkan backend, the Metal backend on my Mac works fine.
To fix this, I updated to the latest versions of vello and winit, and refactored the repo to fix all of the breaking API changes.
Also I removed the "layout" feature from default features, as the "submodules/yoga" submodule doesn't exist.