fix(emscripten): prevent argv use-after-free #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when overriding `argc/argv` from the window location hash, the code built temporary `std::vector<std::string>` and `std::vector<const char*>` on the stack, then reassigned `argv` to their `.data()`. Once the block ended, both vectors were destroyed, leaving `argv` pointing into freed memory (UAF). This patch makes the vectors `static`, ensuring their storage lives for the entire program lifetime and preventing the invalid pointer access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when overriding
argc/argvfrom the window location hash, the code built temporarystd::vector<std::string>andstd::vector<const char*>on the stack, then reassignedargvto their.data(). Once the block ended, both vectors were destroyed, leavingargvpointing into freed memory (UAF).This patch makes the vectors
static, ensuring their storage lives for the entire program lifetime and preventing the invalid pointer access.