[POC] Add message-available callback to CommandQueue#84
Draft
mfazekas wants to merge 1 commit intorive-app:mainfrom
Draft
[POC] Add message-available callback to CommandQueue#84mfazekas wants to merge 1 commit intorive-app:mainfrom
mfazekas wants to merge 1 commit intorive-app:mainfrom
Conversation
Add setMessageAvailableCallback() to CommandQueue so the server can notify the client immediately when response messages are available, instead of relying on polling via processMessages() on the render loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC — looking for feedback, not intended to merge as-is.
Adds
setMessageAvailableCallback()toCommandQueueso the server can notify the client immediately when response messages are written, instead of waiting for the next render loop poll. This is the symmetric counterpart tom_commandConditionVariable.notify_one()that already exists for client→server.Intended use: iOS runtime would use this to
dispatch_asyncaprocessMessages()call, eliminating up to 1 frame of latency on async reads.