fix(guard): add more tokio runtime metrics, remove labels from metrics by MasterPtato · Pull Request #2485 · rivet-dev/actors

MasterPtato · 2025-05-28T21:11:26Z

Changes

MasterPtato · 2025-05-28T21:11:44Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps

PR Summary

This PR enhances Tokio runtime observability while simplifying guard service metrics to reduce cardinality.

Added TOKIO_TASK_TOTAL and TOKIO_ACTIVE_TASK_COUNT metrics in packages/common/runtime/src/metrics.rs for tracking task lifecycle
Removed actor_id, server_id, method, and path labels from PROXY_REQUEST_TOTAL and PROXY_REQUEST_PENDING in packages/edge/infra/guard/core/src/metrics.rs
Simplified PROXY_REQUEST_DURATION to only track status label
Added error tracking via PROXY_REQUEST_ERROR with error_type label
Configured Tokio runtime builder to collect new task metrics in packages/common/runtime/src/lib.rs

_{4 file(s) reviewed, 2 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-05-28T21:12:26Z

+				metrics::PROXY_REQUEST_ERROR
+					.with_label_values(&[&err.to_string()])
+					.inc();


style: Consider using structured error types instead of error.to_string() to avoid high cardinality in error labels

greptile-apps · 2025-05-28T21:12:26Z

+			metrics::PROXY_REQUEST_PENDING.inc();

-			metrics::PROXY_REQUEST_TOTAL
-				.with_label_values(&[&actor_id_str, &server_id_str, method_str, &path])
-				.inc();
+			metrics::PROXY_REQUEST_TOTAL.inc();


logic: Metrics incremented before error handling - could lead to inaccurate counts if subsequent operations fail

cloudflare-workers-and-pages · 2025-05-28T21:14:56Z

Deploying rivet with Cloudflare Pages

Latest commit:	`0bf9b0a`
Status:	✅ Deploy successful!
Preview URL:	https://f83682c1.rivet.pages.dev
Branch Preview URL:	https://05-28-fix-guard-add-more-tok.rivet.pages.dev

View logs

cloudflare-workers-and-pages · 2025-05-29T21:03:53Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`0bf9b0a`
Status:	✅ Deploy successful!
Preview URL:	https://9b699cf3.rivet-studio.pages.dev
Branch Preview URL:	https://05-28-fix-guard-add-more-tok.rivet-studio.pages.dev

View logs

cloudflare-workers-and-pages · 2025-05-29T21:07:21Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`0bf9b0a`
Status:	✅ Deploy successful!
Preview URL:	https://255bbf9c.rivet-hub-7jb.pages.dev
Branch Preview URL:	https://05-28-fix-guard-add-more-tok.rivet-hub-7jb.pages.dev

View logs

MasterPtato requested a review from NathanFlurry May 28, 2025 21:11

MasterPtato mentioned this pull request May 28, 2025

fix(guard): add metrics #2480

Closed

MasterPtato mentioned this pull request May 28, 2025

fix(guard): replace internal caches with moka #2481

Closed

greptile-apps Bot reviewed May 28, 2025

View reviewed changes

MasterPtato force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from fca464f to ce70387 Compare May 29, 2025 21:03

MasterPtato mentioned this pull request May 29, 2025

fix(cache): add traces #2489

Closed

MasterPtato mentioned this pull request May 30, 2025

feat: add pb usage metrics, server state #2503

Closed

NathanFlurry force-pushed the 05-28-fix_guard_replace_internal_caches_with_moka branch from fcd1624 to d958baa Compare May 31, 2025 00:39

NathanFlurry force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from ce70387 to 08138ed Compare May 31, 2025 00:39

MasterPtato force-pushed the 05-28-fix_guard_replace_internal_caches_with_moka branch from d958baa to 4134605 Compare May 31, 2025 00:54

MasterPtato force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from 08138ed to f6d2ad5 Compare May 31, 2025 00:54

MasterPtato mentioned this pull request May 31, 2025

chore: fix guard metrics #2504

Closed

NathanFlurry force-pushed the 05-28-fix_guard_replace_internal_caches_with_moka branch from 4134605 to d958baa Compare May 31, 2025 01:01

NathanFlurry force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from f6d2ad5 to 08138ed Compare May 31, 2025 01:01

NathanFlurry mentioned this pull request May 31, 2025

chore: update workspace #2505

Closed

MasterPtato force-pushed the 05-28-fix_guard_replace_internal_caches_with_moka branch from d958baa to 4134605 Compare May 31, 2025 01:04

MasterPtato force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from 08138ed to f6d2ad5 Compare May 31, 2025 01:04

NathanFlurry force-pushed the 05-28-fix_guard_replace_internal_caches_with_moka branch from 4134605 to d958baa Compare May 31, 2025 01:52

NathanFlurry force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from f6d2ad5 to 08138ed Compare May 31, 2025 01:52

NathanFlurry mentioned this pull request May 31, 2025

feat(guard): add http ping endpoint to edge api hosts #2506

Closed

MasterPtato force-pushed the 05-28-fix_guard_replace_internal_caches_with_moka branch from d958baa to 4134605 Compare May 31, 2025 02:05

MasterPtato force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from 08138ed to f6d2ad5 Compare May 31, 2025 02:05

fix(guard): add more tokio runtime metrics, remove labels from metrics

0bf9b0a

MasterPtato force-pushed the 05-28-fix_guard_replace_internal_caches_with_moka branch from 4134605 to 6caa5bf Compare June 2, 2025 18:13

MasterPtato force-pushed the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch from f6d2ad5 to 0bf9b0a Compare June 2, 2025 18:13

MasterPtato mentioned this pull request Jun 2, 2025

fix: fix pb metrics standalone #2518

Closed

graphite-app Bot closed this Jun 3, 2025

graphite-app Bot deleted the 05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics branch June 3, 2025 07:03

github-actions Bot mentioned this pull request Jun 3, 2025

chore(main): release 25.5.1 #2423

Merged

Navigation Menu

Uh oh!

fix(guard): add more tokio runtime metrics, remove labels from metrics - #2485

fix(guard): add more tokio runtime metrics, remove labels from metrics#2485
MasterPtato wants to merge 1 commit into
05-28-fix_guard_replace_internal_caches_with_mokafrom
05-28-fix_guard_add_more_tokio_runtime_metrics_remove_labels_from_metrics

MasterPtato commented May 28, 2025

Uh oh!

MasterPtato commented May 28, 2025 •

edited

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot May 28, 2025

Uh oh!

greptile-apps Bot May 28, 2025

Uh oh!

cloudflare-workers-and-pages Bot commented May 28, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented May 29, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented May 29, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

MasterPtato commented May 28, 2025

Changes

Uh oh!

MasterPtato commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps Bot May 28, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot May 28, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages Bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages Bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages Bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MasterPtato commented May 28, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented May 28, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented May 29, 2025 •

edited

Loading

cloudflare-workers-and-pages Bot commented May 29, 2025 •

edited

Loading