feat(runtime-core): env-override the native sidecar frame timeout#1641
Draft
khaled-mansour-zid wants to merge 1 commit into
Draft
feat(runtime-core): env-override the native sidecar frame timeout#1641khaled-mansour-zid wants to merge 1 commit into
khaled-mansour-zid wants to merge 1 commit into
Conversation
NATIVE_SIDECAR_FRAME_TIMEOUT_MS is hardcoded to 120_000 and is the value both sidecar spawn sites pass as `frameTimeoutMs`. A single long-running host request maps to one protocol frame, so workloads with legitimately long turns (an agent turn with many tool calls, media generation, etc.) exceed 120s and get killed mid-turn with "timed out waiting for sidecar protocol frame". There is currently no way to raise it without editing the source. Make the const resolve from AGENTOS_SIDECAR_FRAME_TIMEOUT_MS (validated: finite, positive), falling back to 120_000. The native sidecar is process-global (spawned once and multiplexed), so an env override is the right surface rather than a per-AgentOs.create option. Behavior is unchanged when the env var is unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NATIVE_SIDECAR_FRAME_TIMEOUT_MS(packages/runtime-core/src/sidecar-process.ts) is hardcoded to120_000and is the value both native-sidecar spawn sites pass asframeTimeoutMs(packages/core/src/agent-os.ts,packages/core/src/runtime-compat.ts). There is currently no way to raise it without editing the source.Why
A single long-running host request maps to one sidecar protocol frame. Workloads with legitimately long turns — an agent turn with many tool calls, media/asset generation, etc. — exceed 120s and are killed mid-turn with
timed out waiting for sidecar protocol frame, which tears down the sidecar and hangs the turn.Change
Resolve the const from
AGENTOS_SIDECAR_FRAME_TIMEOUT_MS(validated finite + positive), falling back to120_000. Behavior is unchanged when the env var is unset.The native sidecar is process-global (spawned once and multiplexed across sessions), so an env override is the correct surface — a per-
AgentOs.createoption would be ambiguous for a shared process. Happy to expose it throughAgentOsOptionsinstead if you'd prefer, but env matches the shared-resource model.Notes