Skip to content

debug: DO NOT MERGE — instrument core vitest CI timeouts #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NathanFlurry wants to merge 1 commit into from
Closed

debug: DO NOT MERGE — instrument core vitest CI timeouts #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export class StdioSidecarProcess {
private constructor(child: ChildProcessWithoutNullStreams) {
this.child = child;
this.child.stderr.on("data", (chunk: Buffer | string) => {
console.error(`DBGSIDECAR ${String(chunk).trimEnd()}`);
this.stderrChunks.push(
typeof chunk === "string" ? Buffer.from(chunk) : Buffer.from(chunk),
);
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/test-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3174,6 +3174,7 @@ class NativeKernel implements Kernel {
try {
return await fn();
} finally {
console.error(`DBGBOOT ${phase} ${Math.round(performance.now() - start)}ms`);
this.options.onBootTiming?.({
phase,
durationMs: performance.now() - start,
Expand All @@ -3186,6 +3187,7 @@ class NativeKernel implements Kernel {
try {
return fn();
} finally {
console.error(`DBGBOOT ${phase} ${Math.round(performance.now() - start)}ms`);
this.options.onBootTiming?.({
phase,
durationMs: performance.now() - start,
Expand Down
26 changes: 6 additions & 20 deletions scripts/ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,12 @@ run_step() {
"$@"
}

# DEBUG DRAFT — DO NOT MERGE: minimal repro of the core vitest CI timeouts.
run_step pnpm install --frozen-lockfile
run_step pnpm build
run_step pnpm run check-generated
run_step pnpm check-types
run_step node --test scripts/check-secure-exec-boundary.test.mjs
run_step node scripts/check-secure-exec-boundary.mjs
run_step node --test scripts/check-no-escaping-local-deps.test.mjs
run_step node scripts/check-no-escaping-local-deps.mjs
run_step pnpm --dir scripts/publish run check-types
run_step pnpm --dir scripts/publish test
run_step cargo fmt --check
run_step cargo clippy --workspace --all-targets -- -D warnings
# Service fs/shell regression tests stage guest WASM command binaries
# (registry/native or packages/core/commands) and fail hard when missing.
run_step pnpm exec turbo run build --filter=@secure-exec/core...
run_step cargo build -p secure-exec-sidecar
run_step make -C registry/native wasm
run_step node packages/core/scripts/copy-wasm-commands.mjs
run_step env CARGO_INCREMENTAL=0 cargo test --workspace -- --test-threads=1

if [[ "${CI_FORK_PULL_REQUEST:-0}" == "1" ]]; then
run_step pnpm exec turbo run test --concurrency=1
else
run_step env SECURE_EXEC_E2E_NETWORK=1 pnpm exec turbo run test --concurrency=1
fi
cd packages/core
run_step pnpm exec vitest run --no-file-parallelism tests/mount-fs-custom-vfs.test.ts tests/node-runtime-exec-output.test.ts
exit 0
Loading