fix: enable otel logs #3157
fix: enable otel logs #3157
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
commit: |
| } | ||
|
|
||
| fn init_logger_provider() -> SdkLoggerProvider { | ||
| let exporter = opentelemetry_otlp::LogExporter::builder() |
There was a problem hiding this comment.
i'm not sure this is a good idea to use the native log exporter. iirc it's better to capture logs from stdout so we can capture panics, etc.
i looked in to this a while ago, this seems to be the balance that people go for.
my main concern though is there anything that we don't log that might be vital? is it going to be a pain in the ass to re-merge logs with traces? is there a hybrid option? is sentry enough for hard crashes if we use this for logs?
graphite-app
bot
changed the base branch from
10-09-fix_pb_tunnel_gateway_refactor_error_handling
to
graphite-base/3157
MasterPtato
force-pushed
the
10-10-fix_enable_otel_logs
branch
from
29953c1 to
4fef21c
Compare
MasterPtato
force-pushed
the
graphite-base/3157
branch
from
28304d5 to
f8f5890
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
2 participants
No description provided.