chore: update byte units on frontend#4444
chore: update byte units on frontend#4444MasterPtato wants to merge 1 commit into03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_getfrom
Conversation
|
🚅 Deployed to the rivet-pr-4444 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code Review: PR 4444SummaryThis PR corrects byte unit terminology throughout the billing frontend, changing SI prefixes (KB, MB, GB, TB) to IEC binary prefixes (KiB, MiB, GiB, TiB). The change is correct because the actual computation was already using powers of 1024, so the labels were misleading. The PR also refactors What Is Good
Issues FoundPre-existing inconsistency surfaced by this PRIn Numerical impact of the unit changeThis PR changes actual threshold values in Minor Notes
VerdictThe PR is clean and correct in its intent. Before merging: (1) clarify and fix the division by |
f1b6d0a to
d4011f0
Compare
5b2bead to
cfc4fad
Compare
d4011f0 to
3b845cb
Compare
cfc4fad to
65280b5
Compare
65280b5 to
84dbf32
Compare
3b845cb to
1028b2c
Compare
84dbf32 to
90c2e97
Compare
1028b2c to
88d15c3
Compare
88d15c3 to
ede07de
Compare
90c2e97 to
ebdaa13
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: