Skip to content

chore: theme foundry development updates#4461

Open
NathanFlurry wants to merge 21 commits intomainfrom
ralph/frontend-theme-foundry
Open

chore: theme foundry development updates#4461
NathanFlurry wants to merge 21 commits intomainfrom
ralph/frontend-theme-foundry

Conversation

@NathanFlurry
Copy link
Member

Summary

Configured frontend for staging API and fixed Vite build issues to enable theme development. Added before/after screenshots for theme comparison and updated CSS variables and component styling.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Dev server verified running against staging API and rendering theme changes correctly.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings

NathanFlurry and others added 20 commits March 19, 2026 16:58
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@railway-app
Copy link

railway-app bot commented Mar 20, 2026

🚅 Deployed to the rivet-pr-4461 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Mar 21, 2026 at 5:07 pm
frontend-inspector 😴 Sleeping (View Logs) Web Mar 20, 2026 at 2:54 am
website ❌ Build Failed (View Logs) Web Mar 20, 2026 at 2:50 am
mcp-hub ✅ Success (View Logs) Web Mar 20, 2026 at 2:48 am
ladle ❌ Build Failed (View Logs) Web Mar 20, 2026 at 2:47 am

@claude
Copy link

claude bot commented Mar 20, 2026

PR Review: chore: theme foundry development updates

This PR updates the frontend theme (CSS variables, fonts, colors) and adds a Ralph autonomous agent loop script. Overall the changes are clean, but there are a few issues worth addressing.

Issues

1. .env commits staging API URL
File: frontend/.env

VITE_APP_API_URL is changed from http://localhost:43708/api to https://api.staging.rivet.dev. This would break local development for all other developers whose pnpm dev would then point at staging instead of a local server. This should be reverted or moved to .env.local (which is gitignored).

2. rivet.gg domain in .env violates project convention
File: frontend/.env

VITE_APP_ASSETS_URL=https://assets2.rivet.gg uses the deprecated rivet.gg domain. Per project conventions, this should be migrated to rivet.dev. This appears to be a pre-existing value that was not updated alongside the staging URL change.

3. scripts/ralph/.last-branch should be gitignored
File: scripts/ralph/.last-branch

This tracking file is committed (containing ralph/frontend-theme-foundry) but is runtime agent state, similar to prd.json and progress.txt which are already gitignored. Add it to .gitignore alongside the other ralph state files.

4. ralph.sh date arithmetic is Linux-only
File: scripts/ralph/ralph.sh

date -d "..." +%s is a GNU/Linux extension that fails on macOS. The duration calculations will break on non-Linux systems. Consider using $SECONDS for elapsed time tracking instead, which is portable across bash environments.

5. Duplicate Google Fonts imports across two theme files
Files: frontend/src/components/theme.css and frontend/packages/components/public/theme.css

Both files now contain an identical IBM Plex Sans/Mono @import. If both are loaded on the same page, the font will be requested twice. Consider centralizing the import so only one file is the source of truth.

6. Hardcoded hex colors in workflow visualizer
File: frontend/src/components/actors/workflow/xyflow-nodes.tsx

The new colors (#ffa198, #7ee787) are hardcoded hex values, consistent with the pre-existing pattern. Since this PR is actively updating the color palette, it may be worth mapping these to CSS variables (--destructive, a success token) to stay in sync with future theme changes.

Positives

  • Replacing bg-amber-950/50 border-amber-900 with bg-warning/10 border-warning/20 is a good improvement - warning colors now correctly reference semantic tokens rather than hardcoded amber shades.
  • The zod v4/core alias in vite.base.config.ts is a clean fix for the Vite build issue.
  • CSS variable values are now cleaner with a neutral palette (rounded numbers, no warm tint).
  • Font change to IBM Plex Sans/Mono is consistent across all CSS files.
  • The Ralph agent CLAUDE.md instructions are thorough and well-structured.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 20, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4461

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4461

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4461

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4461

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4461

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4461

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4461

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4461

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4461

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4461

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4461

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4461

commit: 2ea33d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant