fix(rivetkit): warn when manager port falls back to a different port#4489
Conversation
|
🚅 Deployed to the rivet-pr-4489 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: fix(rivetkit): warn when manager port falls back to a different portThis is a small, focused change that adds a warning log when FeedbackLogging format The warning uses a template string inside the logger().warn({
msg: `port ${configuredManagerPort} is in use, using ${managerPort}`,
});Per the project's structured logging conventions in CLAUDE.md:
The same principle should apply to the TypeScript logger. The structured data (ports) should be separate fields rather than interpolated into the message string: logger().warn({
msg: "manager port is in use, falling back to a different port",
configuredPort: configuredManagerPort,
actualPort: managerPort,
});This makes the log easier to query/filter programmatically in log aggregation tools. Message casing The message is already lowercase, consistent with the project's convention. No issues here. SummaryThe change is correct and addresses a real UX gap — previously, port fallback happened silently. The only suggested improvement is to follow the project's structured logging style by separating port values into named fields rather than interpolating them into the message string. |

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: