Skip to content

Add backoff to DynamoDB client CreateTableIfNotExists function #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chelseajonesr merged 1 commit into from
May 5, 2025
Merged

Add backoff to DynamoDB client CreateTableIfNotExists function #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions internal/dynamodbutils/dynamodbclient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"context"
"errors"
"fmt"
"math"
"time"

"github.com/aws/aws-sdk-go-v2/aws"
Expand Down Expand Up @@ -52,6 +53,13 @@ func CreateTableIfNotExists(c Client, name string, cti dynamodb.CreateTableInput
return fmt.Errorf("failed to create table after %d attempts", maxAttempts)
}

if attemptNumber > 0 {
maxDelay := 5 * time.Second
retryDelay := min(time.Duration(math.Pow(1.5, float64(attemptNumber-1)))*time.Second, maxDelay)
log.Debugf("delta-go: Sleeping for %s before retrying table create operation", retryDelay)
time.Sleep(retryDelay)
}

result, err := c.DescribeTable(context.TODO(), &dynamodb.DescribeTableInput{
TableName: aws.String(name),
})
Expand All @@ -69,7 +77,6 @@ func CreateTableIfNotExists(c Client, name string, cti dynamodb.CreateTableInput
if result == nil || result.Table == nil {
attemptNumber++
log.Infof("delta-go: Waiting for %s table creation", name)
time.Sleep(1 * time.Second)
continue
} else {
status = string(result.Table.TableStatus)
Expand All @@ -84,7 +91,6 @@ func CreateTableIfNotExists(c Client, name string, cti dynamodb.CreateTableInput
} else if status == "CREATING" {
attemptNumber++
log.Infof("delta-go: Waiting for %s table creation", name)
time.Sleep(1 * time.Second)
continue
} else {
attemptNumber++
Expand Down