Skip to content

[pull] master from pion:master #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 934 commits into
base: master
Choose a base branch
from
Open

[pull] master from pion:master #85

wants to merge 934 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 11, 2020

See Commits and Changes for more details.


Created by pull[bot]. Want to support this open source service? Please star it : )

@pull pull bot added the ⤵️ pull label Sep 11, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2020

Codecov Report

Merging #85 into master will decrease coverage by 3.79%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   75.49%   71.70%   -3.80%     
==========================================
  Files          73       53      -20     
  Lines        5959     1947    -4012     
==========================================
- Hits         4499     1396    -3103     
+ Misses       1104      453     -651     
+ Partials      356       98     -258     
Flag Coverage Δ
#go ?
#wasm 71.70% <87.50%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dtlsrole.go 68.96% <ø> (-31.04%) ⬇️
pkg/media/samplebuilder/samplebuilder.go 91.22% <ø> (-1.53%) ⬇️
stats.go 0.00% <ø> (-62.07%) ⬇️
icecandidate.go 68.04% <85.71%> (-9.82%) ⬇️
peerconnection_js.go 67.00% <100.00%> (-1.58%) ⬇️
icetcp.go 0.00% <0.00%> (-100.00%) ⬇️
sdpsemantics.go 0.00% <0.00%> (-100.00%) ⬇️
icecandidatepair.go 0.00% <0.00%> (-80.00%) ⬇️
gathering_complete_promise.go 50.00% <0.00%> (-50.00%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ed6ee...0786371. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #85 into master will decrease coverage by 1.33%.
The diff coverage is 64.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   75.49%   74.16%   -1.34%     
==========================================
  Files          73       74       +1     
  Lines        5959     5295     -664     
==========================================
- Hits         4499     3927     -572     
+ Misses       1104     1006      -98     
- Partials      356      362       +6     
Flag Coverage Δ
#go 75.63% <64.46%> (-1.50%) ⬇️
#wasm 71.94% <72.05%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dtlsrole.go 100.00% <ø> (ø)
internal/mux/endpoint.go 22.22% <0.00%> (-3.71%) ⬇️
pkg/media/samplebuilder/samplebuilder.go 91.22% <ø> (-1.53%) ⬇️
quictransport.go 56.33% <0.00%> (-3.67%) ⬇️
rtptransceiverdirection.go 86.20% <0.00%> (-4.12%) ⬇️
stats.go 67.85% <0.00%> (+5.78%) ⬆️
rtpreceiver.go 48.06% <8.69%> (-5.33%) ⬇️
icetransport.go 69.33% <12.50%> (-3.45%) ⬇️
rtpsender.go 74.44% <20.00%> (-2.26%) ⬇️
datachannel.go 79.26% <33.33%> (-1.02%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ed6ee...69bfb58. Read the comment docs.

Sean-Der and others added 19 commits March 18, 2024 09:33
Old versions of Pion break against it
Allows the user to cap the retranmission timeout, this change adds
RTOMax to SettingEngine and pass it on when creating the SCTP Assocation
Skip registering the default codecs and interceptors in
NewPeerConnection.
The NewAPI() function already registers them by default  (since #2630)
RTOMax wasn't actually being stored, is being pulled directly from
SettingEngine
Create WHIP/WHEP example works with OBS or browser

Resolves #2499
This allows users of detached datachannels to garbage collect
resources associated with the datachannel and the sctp stream.
There is no functional change here.
Update lint scripts and CI configs.
Chrome doesn't include the msid when responding to
recvonly transceivers

See crbug[0] for discussion

[0] https://issues.chromium.org/u/1/issues/328522463
Update lint scripts and CI configs.
San9H0 and others added 30 commits April 7, 2025 23:44
Wait for PeerConnection to reach 'connected' in NACK test. Otherwise
test will fail.
Don't use same error in goroutine
If IPv6 is supported assert that Pion can connect via it.

Resolves #1315
Generated by renovateBot
It simplifies tracking amount of unsent data for all data channels,
including ones in closing state. Especially useful for IoT apps
which use multiple data channels and have to monitor memory usage.
H265 will be available by default now
TestBadCertificate is no longer needed for 1.24+

```
CreateCertificate will now generate a serial number using
a RFC 5280 compliant method when passed a template with a
nil Certificate.SerialNumber field, instead of failing.
```
Before pion/sctp would always do 1228
Move to the new RTP API newPacketizerWithOptions, add WithRTPTimestamp
To make it possible to set the initial RTP timestamp for the track.
Return an error if a candidate with a username fragment that does
not match the username fragment in the remote description is added.
This usually indicates that the candidate was generated before the
renegotiation.
TrackEndcodings could change when reading
Go WASM interop supports x509, PEM and other cryptography functions
(but not all), so there is no reason not to include those in
the wasm build.

This will also fix compilation errors for when something is
using webrtc and targets both wasm and server

The PR was tested locally (via a simple web folder with wasm_exec.js
and index.html) and I confirmed being able to generate a X509
certificate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.