Skip to content

Show correct context menu when using Menu key#3550

Merged
notxvilka merged 2 commits intorizinorg:devfrom
PremadeS:menu-key-context-menu
Feb 6, 2026
Merged

Show correct context menu when using Menu key#3550
notxvilka merged 2 commits intorizinorg:devfrom
PremadeS:menu-key-context-menu

Conversation

@PremadeS
Copy link
Contributor

@PremadeS PremadeS commented Feb 5, 2026

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've updated the documentation with the relevant information (if needed)
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Opening context menu using the "Menu" key from the keyboard opens a generic context menu as if the user clicked outside of any instructions, both in disassembly and graph widgets. This PR fixes that specific case

Test plan (required)

Since not a lot of systems come with the "Menu" key, one can remap a key to behave as "Menu" key to test this PR

Wasn't able to find a working solution to get the "Menu/Application" key working on macOS both with and without remapping
See context-menu-right-click-keyboard-shortcut-in-mac-os-x

Steps:

  • Open cutter with or without binary
  • Go to Disassembly widget
  • Press the "Menu" key (or the remapped key)
  • Test the actions within the context menu to make sure they work for the currently selected instruction
  • Repeat for Graph widget, also test when no graphs are available

Note that context menu opened through keyboard appears in the middle of the widget that currently has focus, (that's handled by Qt)

Closing issues

closes #2107

Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@notxvilka notxvilka merged commit ab29174 into rizinorg:dev Feb 6, 2026
14 checks passed
@PremadeS PremadeS deleted the menu-key-context-menu branch February 6, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening disassembly context menu using keyboard

3 participants