Fix shortcut for Rename operates on wrong line/address (#2631)#3553
Open
0xSec1 wants to merge 1 commit intorizinorg:devfrom
Open
Fix shortcut for Rename operates on wrong line/address (#2631)#35530xSec1 wants to merge 1 commit intorizinorg:devfrom
0xSec1 wants to merge 1 commit intorizinorg:devfrom
Conversation
wargio
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This change resolves issue #2631, where rename using shortcut operates on wrong line/address.
Problem
When a user uses shortcut for renaming(N) a function and using seek bar, seeks to a address which triggers
on_seekChangedand cursor position is updated butsetCurHighlightedWordwhich updates renaming options is not used.Fix
This modification adds
setCurHighlightedWordat current cursor so it correctly triggers renaming options.Test plan (required)
The following is example of this bug:
before.mp4
After modification, now after seek it correctly renames line/function
after.mp4
Closing issues
closes #2631