Refactor: use rizin api for setting fcn calling convention#3616
Open
PremadeS wants to merge 4 commits into
Open
Refactor: use rizin api for setting fcn calling convention#3616PremadeS wants to merge 4 commits into
PremadeS wants to merge 4 commits into
Conversation
notxvilka
approved these changes
May 26, 2026
Contributor
|
Yes, it doesn't resolve the main issue (rizinorg/rizin#5859) but improves the code a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Use
rz_analysis_function_set_cc()api to set function calling conventionLogic wise nothing changed, calling convention of the function can still be changed through:
Right Click -> Edit Function (Shift + P) -> Calling conventionA bit confused about the issue description (#3513) because cutter had the ability to change calling conventions long before the issue was opened.
Adding a new separate option in the menu itself, outside the Edit function dialog would be redundant in my opinion (if that what the user wants) , unless I've completely misinterpreted the issue
Test plan (required)
afiin the console windowClosing issues
closes #3513
closes #3542