Skip to content

Update rizin to latest dev#3618

Merged
PremadeS merged 5 commits into
rizinorg:devfrom
PremadeS:update-rizin-dev-zlib
Jun 2, 2026
Merged

Update rizin to latest dev#3618
PremadeS merged 5 commits into
rizinorg:devfrom
PremadeS:update-rizin-dev-zlib

Conversation

@PremadeS

@PremadeS PremadeS commented May 31, 2026

Copy link
Copy Markdown
Collaborator

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've updated the documentation with the relevant information (if needed)
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Updates rizin to latest dev to resolve CI erros
Also adds zlib in windows runner because it's required by rz-ghidra now. see rz-ghidra pull #387

Macos runners will most likely fail because rizin expects two arguments for init and fini functions - see log below

log (OUTDATED):

../src/yara_plugin.c:1022:10: error: incompatible function pointer types initializing 'RzCorePluginInitCallback' (aka 'bool (*)(struct rz_core_t *, void **)') with an expression of type 'bool (RzCore *)' (aka 'bool (struct rz_core_t *)') [-Wincompatible-function-pointer-types]
        .init = yara_plugin_init,
                ^~~~~~~~~~~~~~~~
../src/yara_plugin.c:1023:10: error: incompatible function pointer types initializing 'RzCorePluginCallback' (aka 'bool (*)(struct rz_core_t *, void *)') with an expression of type 'bool (RzCore *)' (aka 'bool (struct rz_core_t *)') [-Wincompatible-function-pointer-types]
        .fini = yara_plugin_fini,
...
../src/sil_plugin.c:166:10: error: incompatible function pointer types initializing 'RzCorePluginInitCallback' (aka 'bool (*)(struct rz_core_t *, void **)') with an expression of type 'bool (RzCore *)' (aka 'bool (struct rz_core_t *)') [-Wincompatible-function-pointer-types]
        .init = sil_plugin_init,
...

could suppress the error, but better if updated in respective repositories

Test plan (required)

  • CI is green (apart from both macos ones)

Closing issues

@PremadeS PremadeS requested review from Rot127, notxvilka and wargio June 1, 2026 10:29
@wargio

wargio commented Jun 2, 2026

Copy link
Copy Markdown
Member

i'm going to update the plugin now

@wargio

wargio commented Jun 2, 2026

Copy link
Copy Markdown
Member

I have updated the sources of rz-sil and rz-libyara.

@PremadeS

PremadeS commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

CI is 🟢

@notxvilka notxvilka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait until rizinorg/rizin#6457 is merged, then use the corresponding commit

@notxvilka

Copy link
Copy Markdown
Contributor

Please wait until rizinorg/rizin#6457 is merged, then use the corresponding commit

It was merged btw.

@PremadeS PremadeS merged commit 12c119f into rizinorg:dev Jun 2, 2026
23 of 24 checks passed
@PremadeS PremadeS deleted the update-rizin-dev-zlib branch June 2, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants