Skip to content

Conversation

@AppleMangoOrange
Copy link

Relates to rizinorg/rizin#5790

I have the source .s file, should it be included in the PR?

Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readelf says there are no relocations in this file:

readelf -a avr_relocs.elf 
ELF Header:
  Magic:   7f 45 4c 46 01 01 01 00 00 00 00 00 00 00 00 00 
  Class:                             ELF32
  Data:                              2's complement, little endian
  Version:                           1 (current)
  OS/ABI:                            UNIX - System V
  ABI Version:                       0
  Type:                              EXEC (Executable file)
  Machine:                           Atmel AVR 8-bit microcontroller
  Version:                           0x1
  Entry point address:               0x0
  Start of program headers:          52 (bytes into file)
  Start of section headers:          66820 (bytes into file)
  Flags:                             0x6, avr:6
  Size of this header:               52 (bytes)
  Size of program headers:           32 (bytes)
  Number of program headers:         2
  Size of section headers:           40 (bytes)
  Number of section headers:         9
  Section header string table index: 6

Section Headers:
  [Nr] Name              Type            Addr     Off    Size   ES Flg Lk Inf Al
  [ 0]                   NULL            00000000 000000 000000 00      0   0  0
  [ 1] .data             PROGBITS        00800200 01007a 000004 00  WA  0   0  1
  [ 2] .text             PROGBITS        00000000 000074 010006 00  AX  0   0  2
  [ 3] .stab             PROGBITS        00000000 010080 00009c 0c      4   0  4
  [ 4] .stabstr          STRTAB          00000000 01011c 00000e 00      0   0  1
  [ 5] .avr.prop         PROGBITS        00000000 01012a 000009 00      0   0  1
  [ 6] .shstrtab         STRTAB          00000000 0104c3 000040 00      0   0  1
  [ 7] .symtab           SYMTAB          00000000 010134 0001f0 10      8   9  4
  [ 8] .strtab           STRTAB          00000000 010324 00019f 00      0   0  1
Key to Flags:
  W (write), A (alloc), X (execute), M (merge), S (strings), I (info),
  L (link order), O (extra OS processing required), G (group), T (TLS),
  C (compressed), x (unknown), o (OS specific), E (exclude),
  D (mbind), p (processor specific)

There are no section groups in this file.

Program Headers:
  Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
  LOAD           0x000074 0x00000000 0x00000000 0x10006 0x10006 R E 0x2
  LOAD           0x01007a 0x00800200 0x00010006 0x00004 0x00004 RW  0x1

 Section to Segment mapping:
  Segment Sections...
   00     .text 
   01     .data 

There is no dynamic section in this file.

There are no relocations in this file.

The decoding of unwind sections for machine type Atmel AVR 8-bit microcontroller is not currently supported.


@Rot127
Copy link
Member

Rot127 commented Jan 19, 2026

I have the source .s file, should it be included in the PR?

Yes please.

@AppleMangoOrange
Copy link
Author

AppleMangoOrange commented Jan 19, 2026

Readelf says there are no relocations in this file:

Oops, I compiled the .elf incorrectly. Sorry, I'll fix it right away.

Yes please.

Where should it be added?

@Rot127
Copy link
Member

Rot127 commented Jan 19, 2026

Where should it be added?

Into the src directory in some avr sub-directory please

@AppleMangoOrange AppleMangoOrange marked this pull request as ready for review January 20, 2026 09:16
@Rot127
Copy link
Member

Rot127 commented Jan 21, 2026

Sorry I forgot about it. But could you add the build instructions as a comment into the source file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants