Skip to content

Conversation

@antonangeloff
Copy link
Contributor

@antonangeloff antonangeloff commented Jan 3, 2026

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Fix for a couple of bugs:

  • Invalid checksum calculation when writing a new SREC file - as a result the file cannot be opened later by the IO plugin
  • Incorrect calculation of the size of the last S-record - writing 1 byte less than it should
  • Moved a misplaced EOF check that caused the parser to exit after the first S3 (32-bit address) record is parsed (remaining records get ignored)

Test plan

Added an integration test + changes in some SREC files

Closing issues

None

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.77%. Comparing base (5733f05) to head (5561dd2).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
librz/io/p/io_srec.c 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/io/p/io_srec.c 55.23% <50.00%> (+8.36%) ⬆️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5733f05...5561dd2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@notxvilka notxvilka merged commit 8341909 into rizinorg:dev Jan 4, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants