Closed
Conversation
- Common types like int, signed char, etc... are being demangled in function params now - Support for custom types in function param list needs to be added. - Support for repeated parameter types.
wargio
reviewed
Jan 4, 2025
Now 180 tests pass out of all. Two tests seem to be wrong at the moment, but will take a look later. TODO - Sequence of identical types - Templates - Function params that have qualifier list in their type
wargio
requested changes
Jan 10, 2025
wargio
reviewed
Jan 14, 2025
wargio
reviewed
Jan 14, 2025
wargio
reviewed
Jan 14, 2025
wargio
reviewed
Jan 14, 2025
Contributor
Author
|
We do need to find a way to test the GNU v2 code more like we do for GNU v3. There are very few examples. Also due to lack of a precise grammar, things like special naming conventions are hard for me to cover. Any suggestions? |
Contributor
Author
|
There are some function parameter types for which tests don't exist. I haven't added them for now, because I won't have any way to test my implementation. |
wargio
reviewed
Jan 17, 2025
From the beginning itself, a single test is passing. Now I just have to keep fixing tests to make the demangler work.
wargio
reviewed
Feb 2, 2025
wargio
reviewed
Feb 2, 2025
Member
|
overall this looks very very good. great job! |
Inline rewriting of boolean values and unsigned int values. - (bool)0 ==> false - (bool)1 ==> true - (unsigned int)N ==> Nu
Templates parameters don't get registered after level 2. This is a guess. ABI is not clear with this. It is possible that after this level it stops detecting builtin types. We'll see...
Lots of green in one go!
Missed to read an 'E' just after expr primary ends
multiple times APPEND_TYPE called because it was outside optional block
Whenever a template is substituted, the type must be forcefully appended to list of detected types. This means, we override the usual way we ignore already detected types.
Slow and steady progress
wargio
reviewed
Apr 20, 2025
1 task
Fixed how to reset detected template types
Even though they're exactly the same in their definitions
notxvilka
requested changes
Apr 28, 2025
src/cplusplus/v3.c
Outdated
|
|
||
| #define REPLACE_GLOBAL_N_WITH_ANON_NAMESPACE 1 | ||
|
|
||
| #if 0 |
Contributor
Author
There was a problem hiding this comment.
This is temporary, it helps in debugging, placing breakpoints conditionally.
| // SPDX-License-Identifier: LGPL-3.0-only | ||
|
|
||
| /** | ||
| * Documentation for used grammar can be found at either of |
There was a problem hiding this comment.
Use Doxygen \file syntax here and everywhere
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove old GPL code from libiberty and completely rewrite both GNU v2 and GNU v3 demanglers with LGPL license.
Work plan :
src/gnu_v2src/cxxTest plan :
Attachments :