Update plugin to work with rizin v0.7.3#11
Conversation
Jegeva
commented
Sep 21, 2024
Jegeva
commented
- Changed the meson to compile with head (0.8)
- Changed a few things to work with protos that changed since 0.6
- added a bin exemple
wargio
left a comment
wargio
left a comment
There was a problem hiding this comment.
Looks good, but i need to check locally
just one micro thing, i dont know how the unit test thing work so i didn't integrated it in the meson. if you know it shouldn't be a big thing :) |
|
tests are executed via |
ok cool i added the test to my branch and i works , think i have to close this one and open another based on the latest commit right ? (not super experienced with merges) |
|
you can push everything here if possible |
|
where are we with that ? |
|
can you squash all the commits and push again? so we run the CI. seems red but i don't know why since the logs expired. |
|
squashed |
There was a problem hiding this comment.
Rename the folder to example (there is a typo) and append example/** at the end of the line here:
https://github.com/rizinorg/rz-libmc7/blob/main/.reuse/dep5#L6
meson.build
Outdated
| libmc7_analysis_deps = libmc7_deps + [rz_analysis_dep] | ||
| shared_library('mc7_analysis', libmc7_analysis_src, | ||
| dependencies: libmc7_analysis_deps, | ||
| libmc7_incs = ['.', 'src','include'] |
There was a problem hiding this comment.
for some reasons it doesn't like this:
meson.build:73:43: ERROR: Unknown variable "libmc7_incs".
There was a problem hiding this comment.
k fixed all, repushing
can you rerun the tests please ?
|
Ok, thanks for the hand holding :) |
2 participants
