Disable network proxies by default #631
Merged
+81
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and allow the user to enable them with the new --enable-network-proxy flag
to accommodate the new option --enable-network-proxy
jgonzac
force-pushed
the
feature/DisableHttpProxy
branch
from
9901faa to
9b3da73
Compare
Owner
|
Thanks @jgonzac for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new flag
--enable-network-proxythat allows the user to specifically use the HTTP proxy environment variables that gRPC takes underneath. Otherwise, these variables are unset by default, avoiding the known error:wrapper: failed with: gRPC call failed: failed to connect to all addresses