Skip to content

autodie is lexically scoped, so must be used in each package #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djerius wants to merge 3 commits into
base: main
Choose a base branch
from
Open

autodie is lexically scoped, so must be used in each package #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
280fb3b
add existing test requirement on Test::Fatal
djerius Apr 13, 2025
a6b44a1
autodie is lexically scoped, so must be used in each package
djerius Apr 13, 2025
ba9d073
bugfix: rmdir won't delete populated directories (discovered after au…
djerius Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dist.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ x_MailingList = http://dzil.org/#mailing-list

[Prereqs / TestRequires]
Test::More = 0.90
Test::Fatal = 0.014

[Prereqs / RuntimeRecommends]
Term::ReadLine::Gnu = 0
Expand Down
5 changes: 4 additions & 1 deletion lib/Dist/Zilla/Tester.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ sub minter { 'Dist::Zilla::Tester::_Minter' }
package
Dist::Zilla::Tester::_Role;

use autodie;
use Moose::Role;

has tempdir_root => (
Expand All @@ -65,7 +66,7 @@ sub minter { 'Dist::Zilla::Tester::_Minter' }
# File::Temp deletes the directory when it goes out of scope
$self->_clear_tempdir_obj;

rmdir $self->tempdir_root if $self->tempdir_root;
Dist::Zilla::Path->new( $self->tempdir_root)->remove_tree if $self->tempdir_root;
return $self->$orig(@_);
};

Expand Down Expand Up @@ -114,6 +115,7 @@ sub minter { 'Dist::Zilla::Tester::_Minter' }
{
package Dist::Zilla::Tester::_Builder;

use autodie;
use Moose;
extends 'Dist::Zilla::Dist::Builder';
with 'Dist::Zilla::Tester::_Role';
Expand Down Expand Up @@ -259,6 +261,7 @@ sub minter { 'Dist::Zilla::Tester::_Minter' }
{
package Dist::Zilla::Tester::_Minter;

use autodie;
use Moose;
extends 'Dist::Zilla::Dist::Minter';
with 'Dist::Zilla::Tester::_Role';
Expand Down