Skip to content

Remove span analyzer #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Remove span analyzer #50

merged 3 commits into from
Aug 12, 2024

Conversation

rjmurillo
Copy link
Owner

@rjmurillo rjmurillo commented Aug 12, 2024

The ECS1000 analyzer for Span<T> is not part of Effective C# and is removed

@rjmurillo rjmurillo added documentation Improvements or additions to documentation analyzers build dependencies Pull requests that update a dependency file releasable github_actions labels Aug 12, 2024
@rjmurillo rjmurillo added this to the v0.1.0 milestone Aug 12, 2024
@rjmurillo rjmurillo changed the base branch from main to release/v0.1.0 August 12, 2024 00:26
@rjmurillo rjmurillo marked this pull request as ready for review August 12, 2024 00:26
@rjmurillo rjmurillo enabled auto-merge (squash) August 12, 2024 00:26
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+6.62% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d17017b) 668 571 85.48%
Head commit (fb26d95) 595 (-73) 548 (-23) 92.10% (+6.62%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#50) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@rjmurillo rjmurillo merged commit c5a55a1 into release/v0.1.0 Aug 12, 2024
8 checks passed
@rjmurillo rjmurillo deleted the remove-span-analyzer branch August 12, 2024 00:47
rjmurillo added a commit that referenced this pull request Aug 19, 2024
The ECS1000 analyzer for `Span<T>` is not part of Effective C# and is
removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzers build dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github_actions releasable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant