Skip to content

Move support to sdk 8 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Move support to sdk 8 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7525534
Move PerfDiff.csproj TFM from net8.0 -> net9.0
rjmurillo Dec 20, 2024
57ba67c
Update global.json to follForward to `patch`
rjmurillo Dec 20, 2024
d170c06
Remove use of obsolete overload Compilation.WithAnalyzers using a Can…
rjmurillo Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,17 @@
These items impact our compatibility with SDK versions, so follow
to strike a balance between compatibility and modernity.

These are the two main documents to reference how the Public API impacts users:
- https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md
These are the three main documents to reference how the Public API impacts users:
- https://github.com/dotnet/roslyn/blob/main/docs/wiki/NuGet-packages.md?plain=1
- https://learn.microsoft.com/en-us/dotnet/core/porting/versioning-sdk-msbuild-vs#lifecycle
- https://learn.microsoft.com/en-us/visualstudio/productinfo/vs-servicing
-->
<PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.3.1" />
<!-- We are using 4.8, which introduces .NET 8 and supports VS 2022 17.8 -->
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8" />
</ItemGroup>
<ItemGroup>
<PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" />
<PackageVersion Include="BenchmarkDotNet" Version="0.13.12" />
<PackageVersion Include="BenchmarkDotNet.Diagnostics.dotTrace" Version="0.13.12" />
<PackageVersion Include="GetPackFromProject" Version="1.0.6" />
Expand Down
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"sdk": {
"version": "9.0.100",
"rollForward": "disable" /* setup-dotnet is broken and we don't want to have differences in CI vs local, so make this disabled */
"rollForward": "patch" /* setup-dotnet is broken and we don't want to have differences in CI vs local, so make this disabled */
},
"msbuild-sdks": {
"DotNet.ReproducibleBuilds.Isolated": "1.2.4"
Expand Down
2 changes: 1 addition & 1 deletion src/tools/PerfDiff/PerfDiff.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net9.0</TargetFramework>
<NonShipping>true</NonShipping>
<ExcludeFromSourceBuild>true</ExcludeFromSourceBuild>
</PropertyGroup>
Expand Down
10 changes: 5 additions & 5 deletions tests/EffectiveCSharp.Analyzers.Benchmarks/Helpers/BenchmarkCSharpCompilationFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ internal static class BenchmarkCSharpCompilationFactory
throw new InvalidOperationException("Failed to create compilation");
}

CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options, CancellationToken.None);
CompilationWithAnalyzers test = compilation.WithAnalyzers([new TAnalyzer()], options, CancellationToken.None);
CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options);
CompilationWithAnalyzers test = compilation.WithAnalyzers([new TAnalyzer()], options);

return (baseline, test);
}
Expand All @@ -35,9 +35,9 @@ internal static class BenchmarkCSharpCompilationFactory
throw new InvalidOperationException("Failed to create compilation");
}

CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options, CancellationToken.None);
CompilationWithAnalyzers test1 = compilation.WithAnalyzers([new TAnalyzer1()], options, CancellationToken.None);
CompilationWithAnalyzers test2 = compilation.WithAnalyzers([new TAnalyzer2()], options, CancellationToken.None);
CompilationWithAnalyzers baseline = compilation.WithAnalyzers([new EmptyDiagnosticAnalyzer()], options);
CompilationWithAnalyzers test1 = compilation.WithAnalyzers([new TAnalyzer1()], options);
CompilationWithAnalyzers test2 = compilation.WithAnalyzers([new TAnalyzer2()], options);

return (baseline, test1, test2);
}
Expand Down
Loading