Open
Conversation
Backend Implementation: - Added omniauth, omniauth-github, jwt, and bcrypt gems - Created User model with encrypted access tokens - Added AuthController for OAuth flow and JWT generation - Added authentication methods to ApplicationController - Updated CORS to support auth headers and credentials - Created migration for users table - Added comprehensive documentation Frontend Implementation: - Created AuthService for managing authentication state - Added LoginButton component with GitHub branding - Added UserProfile component showing user info and VA status - Created AuthCallback component for OAuth flow - Added ProtectedRoute component for access control - Updated Dashboard to include auth UI and headers - Added auth headers to all API requests Security Features: - JWT tokens expire after 24 hours - Access tokens encrypted in database - VA organization membership verification - Protected endpoints with auth requirements Next Steps: - Create GitHub OAuth app - Add environment variables - Test authentication flow 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
8780b5c to
cf5c01d
Compare
- Added vetsapi-pr-review.vercel.app to allowed origins - Already had wildcard support but being explicit for production domain 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Enabled Rails.cache.write for last_refresh_time in all scrapers - Added cache update to fast_pr_scraper.rb - Uncommented cache updates in render_cron_scraper.rb and fixed version - This will make the "Last updated" timestamp update every 15 minutes The timestamp was showing old times because the cache writes were disabled 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Overview of API features and tech stack - Installation and development instructions - API endpoints documentation - Background jobs and cron configuration - Deployment instructions for Render.com - Monitoring and debugging guides - Contributing guidelines
- Remove skip_before_action :verify_authenticity_token from AuthController - This callback doesn't exist in API-only Rails apps (ActionController::API) - Was causing ArgumentError preventing cron jobs from running
- Add explanatory comment about verify_authenticity_token not needed in API apps - Add /health endpoint with version 1.0.1 to verify deployments - This should force Render to rebuild with the fixed code
- Completely remove auth_controller.rb that was causing deployment failures - Comment out auth routes in routes.rb - Update health check version to 1.0.2 - This removes the problematic skip_before_action that was breaking cron jobs - OAuth can be re-implemented later when needed
- Remove User model - Remove user migration - Remove all authentication methods from ApplicationController - Comment out JWT and OAuth gems in Gemfile - Update health check to version 1.0.3 This should finally fix the cron job failures by removing all OAuth-related code that was causing the verify_authenticity_token error
Bumps [pg](https://github.com/ged/ruby-pg) from 1.5.9 to 1.6.1. - [Changelog](https://github.com/ged/ruby-pg/blob/master/CHANGELOG.md) - [Commits](ged/ruby-pg@v1.5.9...v1.6.1) --- updated-dependencies: - dependency-name: pg dependency-version: 1.6.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
cf5c01d to
b2b8ef6
Compare
Author
|
A newer version of pg exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps pg from 1.5.9 to 1.6.1.
Changelog
Sourced from pg's changelog.
... (truncated)
Commits
5da9f3bBump VERSION to 1.6.1f326991Add release notes for pg-1.6.1f181983Merge pull request #657 from larskanis/add-musl3ce8a71Add binary gems foraarch64-linux-muslandx86_64-linux-musl385edebMerge pull request #655 from ged/revert-647-remove_mig95fb237Revert "Remove installation of Macos "mig" tool"c2f3468Merge pull request #653 from larskanis/marshal-compat-array3a9938bMerge pull request #654 from larskanis/remove-binary-dependenciesce0599bMerge pull request #647 from larskanis/remove_migb8ee7b2Merge pull request #651 from larskanis/fixciYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)