fix(shadcn): use native button for select trigger#5117
Open
cocojojo5213 wants to merge 1 commit into
Open
Conversation
2de1453 to
dde3c89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
The shadcn single select trigger is implemented as a custom button-like element. Switching it to a native
<button type="button">gives it browser-managed button and disabled semantics while preserving keyboard activation.This also adds regression coverage for tab navigation,
aria-expanded/aria-haspopup, and disabled trigger behavior.fixes #4764
Checklist
Validation run:
npm --workspace @rjsf/shadcn test -- SelectWidget.test.tsxnpm --workspace @rjsf/shadcn run test:updatenpm --workspace @rjsf/shadcn testnpm --workspace @rjsf/shadcn run cs-checknpm --workspace @rjsf/shadcn run lintnpm --workspace @rjsf/shadcn run build:tsnpm --workspace @rjsf/shadcn run buildnpx nx run-many --target=build --exclude=@rjsf/docs --parallel=2git diff --check