Skip to content

Conversation

@Ivanbeethoven
Copy link
Collaborator

No description provided.

@genedna genedna requested a review from Copilot October 27, 2025 08:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds rootless execution support and documentation for the libfuse-fs project. The main focus is enabling non-root users to run FUSE filesystems by documenting the capability-granting process and changing the default mount mode from privileged to unprivileged.

Key Changes:

  • Changed default mount mode from privileged to unprivileged in passthrough example
  • Added comprehensive documentation for rootless execution with setcap instructions
  • Created automation scripts for running passthrough and overlay filesystem demos
  • Updated version and license format in Cargo.toml

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
project/libfuse-fs/script/run_passthrough.sh New bash script automating passthrough filesystem demo setup and execution
project/libfuse-fs/script/run_overlayfs.sh New bash script automating overlay filesystem demo setup and execution
project/libfuse-fs/examples/passthrough.rs Changed default mount mode to unprivileged and added debug logging initialization
project/libfuse-fs/README.md Added rootless execution documentation, updated example commands, and corrected example binary names
project/libfuse-fs/Cargo.toml Version bump and standardized license format
project/libfuse-fs/.gitignore Added target directory to ignore list

Comment on lines 40 to 41
tracing_subscriber::fmt::init();
debug!("Starting passthrough filesystem with args: {:?}", args);
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The debug! macro is used before its import is visible. The code needs use tracing::debug; or similar import statement to compile successfully.

Copilot uses AI. Check for mistakes.
# Build the example first
cargo build --example passthrough

# Grant capabilities for rootless operation
Copy link

Copilot AI Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relative path ../target/debug/examples/passthrough assumes the command is run from a specific directory. Should document from which directory this command should be executed (likely the project root or libfuse-fs directory).

Suggested change
# Grant capabilities for rootless operation
# Grant capabilities for rootless operation
# Run this command from the project/libfuse-fs directory (crate root)

Copilot uses AI. Check for mistakes.
@Ivanbeethoven Ivanbeethoven added this pull request to the merge queue Oct 27, 2025
Merged via the queue into rk8s-dev:main with commit d194021 Oct 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants