Add Win32 support #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was possible to compile cr_task before with the help of Cygwin, but Windows does not have pthreads. So on Windows, use Windows.h directly. If using C11, MSVC needs the `/experimental:c11atomics` flag.
|
I was thinking about switching to C11 <thread.h> to enable support for Windows. Apart from requiring a relatively recent compiler, are there reasons I might not know about to prefer <Windows.h> for this? |
I was planning to try By the way, this PR technically conflicts with #1 since that one has to indent a small section of code that's touched here, but I'll fix the conflict for you if/once it comes up. |
LoganDark
added a commit
to LoganDark/cr_task.h
that referenced
this pull request
Mar 12, 2024
This was only really implemented on platforms like Windows around 6 months ago, but it seems to work everywhere *now* as long as you're using a recent enough compiler. Closes rkaehn#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to compile cr_task before with the help of Cygwin, but Windows does not have pthreads. So on Windows, use Windows.h directly.
If using C11, MSVC needs the
/experimental:c11atomicsflag.