Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: examples in kalman_filter.py #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Erotemic
Copy link

The code in the Kalman filter example was broken in multiple ways. There were syntax errors, array shape errors, and undefined name errors.

I think I've fixed them in a reasonable way. I've also added a seeded random number generator to make the example deterministic. The only thing I'm not sure about is when I define dt = 1 as a constant, and if cv is the best name for the KalmanFilter instance in this example. Perhaps f is better. Please advise.

I'll also note that perhaps some of these examples might be better written as a doctest. The standard library doctest runner can be a bit annoying, but my xdoctest library works very well and would help ensure that all of the examples actually run.

I can convert this particular example if desired. Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant