Skip to content

Make the directory review comment a clickable checklist#84

Merged
drmowinckels merged 1 commit into
mainfrom
feat/directory-review-checklist
Jul 4, 2026
Merged

Make the directory review comment a clickable checklist#84
drmowinckels merged 1 commit into
mainfrom
feat/directory-review-checklist

Conversation

@drmowinckels

Copy link
Copy Markdown
Member

Summary

Reviewers liked the automated directory review list but wanted to track progress. directory_review_format() now renders it as a task list: each changed entry is a - [ ] checkbox reviewers tick as they go (GitHub renders task lists in PR comments as interactive checkboxes), automated flags are nested under their entry, and the manual minority-gender / photo-crop checks become a short "before merging" checklist.

Rendered example:

Directory sync - automated review

2 automated flags below (shown under the entry). Tick each entry as you review it.

  • alex-albright.json
  • jane-doe-1.json
    • "jane-doe-1" has a numeric suffix - confirm this is a distinct person
    • contact method "Twitter" but social_media.twitter is empty

Before merging, confirm manually:

  • Each person is a minority-gender person (name / image / context)
  • Photos crop to the right area (check the preview build)

Test plan

  • devtools::test() — full suite green (1030); directory_review_format tests updated for the checkbox format.
  • goodpractice clean.

Note: the review comment is re-posted if the sync PR is updated (a fresh unticked checklist). Fine for the weekly cadence; if mid-review re-runs become common, a follow-up could update the comment in place.

🤖 Generated with Claude Code

directory_review_format() now renders each changed entry as a task-list
checkbox reviewers tick as they go (progress is visible at a glance),
with automated flags shown under their entry, plus a "before merging"
checklist for the manual minority-gender and photo-crop checks. GitHub
renders task lists in PR comments as interactive checkboxes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jinx-familiar

jinx-familiar Bot commented Jul 4, 2026

Copy link
Copy Markdown

🎉 Good Practice Check

All checks passed!

Updated: 2026-07-04T19:41:16.640Z

@drmowinckels drmowinckels merged commit 038926b into main Jul 4, 2026
4 checks passed
@drmowinckels drmowinckels deleted the feat/directory-review-checklist branch July 4, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant