dont use folder location for directory image, rely on finding match#458
Open
drmowinckels wants to merge 6 commits into
Open
dont use folder location for directory image, rely on finding match#458drmowinckels wants to merge 6 commits into
drmowinckels wants to merge 6 commits into
Conversation
✅ Deploy Preview for rladies-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after doing alot of debugging on the directory side and here, I realised there was a somewhat cumbersome way of dealing with the directory images.
the directory
photo.urljson element should now just specify the file name, not location, and the hugo theme searches for a match in the assets using pattern*<photo.url>, and thus returning the path to the file to access it.This is more robust and means less hard-coding of paths to deal with if we change the structure.