Add support for additional transaction types and improve CSV parsing #21
+87
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsing Add support for 10 new Schwab transaction types: - Advisor Fee - Reinvest Dividend - Reinvest Shares - Bank Interest - Funds Received - MoneyLink Transfer - Stock Plan Activity - Qualified Dividend - Adjustment - Misc Cash Entry - Service Fee Enhance CSV parsing robustness: - Automatically detect and handle CSV files with or without prefix/suffix rows - Add header validation to ensure CSV format matches expected Schwab format - Handle edge cases: skip prefix/suffix rows only when present, validate header format Improve error handling: - Handle NaN values in remove_currency function and Value column processing - Add proper validation with informative error messages for malformed CSV files Update documentation: - Add new transaction types to supported transactions list - Document automatic CSV format detection and validation behavior
Apply the same currency removal logic to the Fees column that was already applied to the Value column. This ensures consistent processing and prevents potential issues with currency symbols in fee values.
Update example_out.csv to show Fees column without currency symbol, demonstrating the fix for currency symbol removal in the Fees column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for 10 new Schwab transaction types:
Enhance CSV parsing robustness:
Improve error handling:
Update documentation: