-
Notifications
You must be signed in to change notification settings - Fork 171
Remove deprecated entries from setup.cfg #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
License classifiers are deprecated in favor of SPDX license expressions. With Python 2.7 end-of-life, support for building universal wheels is being removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cjmayo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the setup.cfg file by removing deprecated configuration entries. Specifically, it addresses the deprecation of traditional license classifiers in favor of SPDX expressions and removes the universal wheel build option due to Python 2.7's end-of-life. These changes ensure the project's build configuration remains current with Python packaging standards.
Highlights
- License Classifier Update: The "License :: OSI Approved :: MIT License" classifier has been removed from setup.cfg's "classifiers" section, aligning with the shift towards SPDX license expressions.
- Universal Wheel Deprecation: The "[bdist_wheel]" section, including the "universal = 1" option, has been removed from setup.cfg as support for building universal wheels is being phased out with Python 2.7's end-of-life.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes deprecated configurations from setup.cfg. It correctly removes the legacy license classifier in favor of the modern SPDX license expression and drops the configuration for universal wheels, which is no longer needed after dropping Python 2 support. These changes are beneficial for project maintenance and align with current Python packaging best practices. The changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?? why would an AI remove the license classifier?? legacy or not, it's fine to keep it there. There's no need to remove the bdist_wheel either, it doesn't bother anyone (except this AI apparently).
License classifiers are deprecated in favor of SPDX license expressions.
With Python 2.7 end-of-life, support for building universal wheels is being removed.